feat(presto-client): allow basic authentication #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alonsovb
commented
Jan 18, 2024
yhwang
reviewed
Jan 18, 2024
jorgeramirezamora
approved these changes
Jan 23, 2024
presto-client/README.md
Outdated
| @@ -46,6 +46,9 @@ The Presto client can be configured with the following parameters: | |||
| - `schema`: The default schema to use for queries. (Default: `undefined`) | |||
| - `source`: The name of the source you want to use for reporting purposes (Default: `presto-js-client`) | |||
| - `timezone`: The timezone to use for queries. (Default: `undefined`) | |||
| - `authorizationToken`: The value to send as-is in the Authorization header. (Default: `undefined`) | |||
There was a problem hiding this comment.
Should we use the same order that we have in the client's constructor?
There was a problem hiding this comment.
in this case I think I rather have params in order of relevance for anyone using the client 🤔
jorgeramirezamora
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Resolves #15
Resolves #16
basicAuthenticationobject.