Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated info for clarity #1885

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

redsquidz
Copy link

@redsquidz redsquidz commented May 6, 2023

DevkitArm link no longer has devkitpro-pacman.amd64.deb listed; just the pkg file. This was confusing so it should be removed. I've only edited the WS1 entry, others may need to be updated too but I'm on mobile so the interface is difficult lol

Description

Discord contact info

redsquidz#9877

DevkitArm link no longer has `devkitpro-pacman.amd64.deb` listed; just the pkg file. This was confusing so it should be removed. I've only edited the WS1 entry, others may need to be updated too but I'm on mobile so the interface is difficult lol
@GriffinRichards
Copy link
Member

Ok, but is this step no longer required or does an alternative step need to be described?

@redsquidz
Copy link
Author

I had to install armkit for CrystalDust if that's what you mean? I was getting along just fine with my own hack without it

@GriffinRichards
Copy link
Member

No what you had to install for a different repo isn't relevant, just pokeemerald. I'm not on Windows so I don't know what is or isn't currently required.

@redsquidz
Copy link
Author

redsquidz commented May 10, 2023

I would say we could lose the whole step then since i was able to get through without devkitArm... or at the very least include a disclaimer that it's for older builds like CD.

However, if devkitArm is required for other systems, would it also be needed for building repos made on those systems? Not relevant to a personal emerald windows build, but with how many forks are out there mentioning something would go along way to avoid poking the bee's nest, if that cross-platform requirement is true 🤔

@GriffinRichards
Copy link
Member

GriffinRichards commented May 11, 2023

or at the very least include a disclaimer that it's for older builds like CD.

Other repos are not relevant here. They have their own copies of INSTALL.md.

@redsquidz
Copy link
Author

Oh you know that's a good point. I guess there's our answer then!

@GriffinRichards
Copy link
Member

I'm still not clear on what's required for WSL1. The updated instructions are still directing people to download pacman from devkitPro, it's just less specific about what because a package was removed from their GitHub. I'll let some other Windows person chime in.

@redsquidz
Copy link
Author

redsquidz commented May 26, 2023

That's true, it'd be good to have someone test it from scratch before the instruction is dropped entirely.

If we want to close this we could just clear up the pkg/deb confusion. It was the original reason for the PR anyway and would stop any wild goose chases in their tracks, which was all the PR was made for. That first sudo command also threw an error if I'm remembering right

@sophxm
Copy link

sophxm commented May 27, 2023

The existing guidance is outdated, but this proposed change contains unnecessary steps and isn't fully clear (and the Debian/Ubuntu installation remains outdated).

Steps 1-3 for WSL should probably just be replaced with a link to the dkP instructions on their wiki as is done for the Arch instructions.

Steps 1-2 for Debian/Ubuntu can be replaced in the same way (with sudo gdebi devkitpro-pacman.amd64.deb from step 3 also being removed, as was done to WSL step 4 in this commit).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants