Determine required pokedex expansion constants #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhearachel
requested changes
Feb 11, 2024
bbepis
force-pushed
the
pokedex-research
branch
from
e151635 to
10ec382
Compare
lhearachel
requested changes
Feb 11, 2024
bbepis
force-pushed
the
pokedex-research
branch
from
10ec382 to
7dfe9c9
Compare
lhearachel
approved these changes
Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required const replacements to facilitate dex expansion
I'm 95% sure this matches, it gives me the same SHA1 as the main branch, but the main branch gives me a different than expected hash on MSYS (
22a6a027581f8422940e2e1c6d0a41e3ab945e49)I've identified the
UnkStruct_02026324typedef struct as the PokedexData struct, but I didn't do a full typedef rename of it since it'll double the size of this already complex PRFor the .py files edited here, I've improved them so that only one number has to change for the rest of the constants to also change auomatically. However I'm not sure if the existing numbers in them are correct; in code they're directly after NATIONAL_DEX_COUNT instead of SPECIES_BAD_EGG. But since I'm not able to get the expected SHA1 I don't know if I'm paranoid for no reason