-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced decomp list with pret.github.io link #136
base: master
Are you sure you want to change the base?
Conversation
README.md
Outdated
* [**Pokémon Diamond and Pearl**](https://github.com/pret/pokediamond) | ||
* [**Pokémon Platinum**](https://github.com/pret/pokeplatinum) | ||
* [**Pokémon HeartGold and SoulSilver**](https://github.com/pret/pokeheartgold) | ||
* [**Pokémon Mystery Dungeon: Explorers of Sky**](https://github.com/pret/pmd-sky) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At a certain point, it becomes silly to list every side game, and it would be just as effective and more maintainable to just link to the pret org and say "find other projects here".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's discussion about moving this list to a central location, which should serve that purpose once that pans out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That phrasing is confusing to me. There already is a central location for the list. It's https://github.com/pret
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The list isn't ordered by generation, so it's not as user-friendly. I made a PR to pret.github.io to serve as a more organized list to link to, though I don't think it's gained much traction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't even know a github io page had been created. I don't feel like it is necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you want to do with the disassembly list then?
- Merge this PR to update the existing list, following pret's current readme convention.
- Open a discussion to change the current convention for all pret repos.
- Break convention with this repo only, and link to https://github.com/pret
- Close this PR, take no other action, and leave the readme's list in its current out-of-date state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well I'm fine with this being merged for consistency. But the stylization of PRET instead of pret is already merged into several of the repos, and the lists in all of those repos are already out-of-date because they don't include poketcg2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "PRET" stylization was already in a lot of the repos prior to my wave of PRs, so I had followed that originally before it was pointed out to use "pret". I was not aware of TCG 2 when making my PRs, since no repo other than this one mentioned it. You are welcome to make PRs to all the repos to fix them.
1cc1dcf
to
178b5ed
Compare
Replaced with link to pret.github.io. |
No description provided.