Bgmap #140
Bgmap #140
Conversation
|
The entirety of src/data/maps/permissions/gb/ and src/data/maps/permissions/cgb/ are identical so I say we take this opportunity to create just a single src/data/maps/permissions/ and |
|
We could also combine all the duplicate/identical *.dimensions files. Not immediately sure of the best folder organization for that though. (Probably just src/data/maps/dimensions/) |
|
All the .lz.match files in src/data/maps/tiles/gb/ are .bin.lz.match but in src/data/maps/tiles/cgb/ they are all .bgmap.lz.match. |
src/gfx.asm
Outdated
| dw NULL | ||
| db TRUE ; cgb mode | ||
| INCBIN "data/maps/tiles/card_pop.bin.lz" | ||
| INCBIN "data/maps/tiles/cgb/card_pop_noncgb.bgmap.lz" |
There was a problem hiding this comment.
The card_pop_noncgb files are in the cgb folder, but I assume that is because this tilemap has db TRUE ; cgb mode.
What do you think about moving the card_pop_noncgb files to the gb folder (and renaming them to card_pop) for the sake of symmetry?
(Do you think the db TRUE ; cgb mode is a mistake?)
| @@ -25,3 +25,4 @@ | |||
| *.2bpp binary diff=hex | |||
| *.1bpp binary diff=hex | |||
| *.lz binary diff=hex | |||
| *.bgmap binary diff=hex | |||
There was a problem hiding this comment.
Should *.dimensions be added around line 20?
Yep that makes a lot of sense, and it matches. Actually it's important that they are the same for both systems because then you could run into problems if you saved in one system and tried to run in another where the permission is different, so a way to enforce that is to include it twice.
Also makes sense to consolidate, mmmh. I'll play around with the Makefile to see if I can pull that off, instead of deriving the dimensions path through the tool.
My thought process is that .bgmap is only an intermediary file with the tiles and attributes interleaved, but GB tilemaps don't have attributes, so they can be compressed right away. It wouldn't make sense to have a .bgmap for those cases where attributes don't exist. |
Ahh. That makes sense. It's a tiny bummer that when I compare the gb/ and cgb/ folders in Beyond Compare, the different extensions means I can't easily cross-check, but that's not the end of the world. |
Added a tool so that we can convert the CGB tilemaps from tilemap + attributes format to the interleaved format that should be included in the ROM. These intermediate files are distinguished by their .bgmap file extension, and are built from the .bin files that have the tile+attribute pair bytes, for ease of use in tools such as Tilemap Studio. As a consequence, the dimensions of these tilemaps have to be added as files and are not hardcoded inside the .asm code.