Identify and label sfx

[FrenchOrange]

Proper labels for each sound effect. Solves Issue n°54.

[ElectroDeoxys]

Looks good, if I had to nitpick I would suggest names in the infinitive form rather than in the past tense, so "COIN_TOSS" instead of "TOSSED_COIN" and "POKEMON_EVOLUTION" instead of "EVOLVED_POKEMON".

[dannye]

Thanks, fantastic stuff! I left 3 minor suggestions if you agree.

Also, and this is extremely minor, in src/macros/scripts.asm there is:

db \1 ; Sound Effect (ex SFX_56)

where SFX_56 could be replaced with SFX_SAVED_GAME (or SFX_SAVE_GAME).

[dannye]

Here is a bit of code you can add (for example, right after Script_Tech1:) to hear every sound effect:

	call PauseSong
	ld a, 0
.loop
	push af
	call PlaySFX
.wait_sfx
	call AssertSFXFinished
	or a
	jr nz, .wait_sfx
	ld a, 60
	call DoAFrames
	pop af
	inc a
	cp NUM_SFX
	jr nz, .loop
	call ResumeSong

[dannye]

Thanks!!