Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bugs-and-glitches #147

Merged
merged 4 commits into from
May 16, 2024
Merged

Update bugs-and-glitches #147

merged 4 commits into from
May 16, 2024

Conversation

FrenchOrange
Copy link
Contributor

  • Add category headers (for code, gfx, and text), like in the pokecrystal bug docs.
  • Add entry for the Phantom Venusaur bug and the "Ninetails" typo.
  • Document graphical issues (frame data errors and inconsistencies).


([Video](https://youtu.be/vr8MZwW6gpI?si=qZuMBGRSrMyoGVJj&t=60))

The name-checking routine used by Card Pop! to generate what card the player will receive is flawed, preventing one from ever receiving the Venusaur Phantom Card.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually not the root cause of not obtaining the Phantom Venusaur card, it's more of a logical flaw in the implementation and not a technical bug. The fix here merely corresponds to name-checking in the Card Pop! system. (Which might not be a bug because the name checking works in the opposite system, though don't quote me on that...)

Copy link
Contributor Author

@FrenchOrange FrenchOrange May 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, I thought it must have been the root of the issue, especially since it's the only part of card_pop.asm to mention a bug.
Has a fix for "Unobtainable Phantom Venusaur" being made yet, or should I just replace that section with a "TODO"?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a potential fix that is easy, yeah. Although it's arguable whether it's a bug or a design flaw (in pokecrystal those two are different pages, but in poketcg we don't have a page for design flaws).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left it as a todo in the mean time, while we wait for a consensus to be drawn.

bugs_and_glitches.md Outdated Show resolved Hide resolved
@ElectroDeoxys ElectroDeoxys merged commit 973544c into pret:master May 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants