Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macro updates #150

Merged
merged 4 commits into from
Aug 4, 2024
Merged

Macro updates #150

merged 4 commits into from
Aug 4, 2024

Conversation

Rangi42
Copy link
Member

@Rangi42 Rangi42 commented Aug 4, 2024

Fixes #141

Rebase, don't squash

@Rangi42 Rangi42 requested a review from dannye August 4, 2024 14:02
@Rangi42 Rangi42 merged commit a341a11 into pret:master Aug 4, 2024
1 check passed
@Rangi42 Rangi42 deleted the textfw branch August 4, 2024 14:03
@dannye
Copy link
Member

dannye commented Aug 5, 2024

Build with RGBDS 0.8.0, though it is not yet required

@Rangi42 Isn't it required though? Because of the bug in 0.7.0? gbdev/rgbds#1306

That's why I made dannye@7ff2a11 a while ago but never merged it.

@Rangi42
Copy link
Member Author

Rangi42 commented Aug 5, 2024

@dannye Ack, I forgot about that! Would you prefer to switch back to CHARLEN() == 1 checks, or go ahead and require 0.8.0?

@dannye
Copy link
Member

dannye commented Aug 5, 2024

Definitely eager to use incharmap so not a problem to require 0.8.0. I was right about to push the change anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify the _textfw macro with RGBDS 0.7.0's INCHARMAP function
2 participants