Build now uses prettier/standalone
#943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Janther
added
enhancement
fvictorio
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change users won't have to uses aliases when building applications for the browser.
This feature was by 2 users (#942 and another one in the Telegram thread), having issues when building an application for the browser.
Before this fix, webpack was generating code that used
require('prettier'). This would lead to requiring the use of aliases in the webpack configuration so'prettier'would be resolved to'prettier/standalone'.With this change, users will still be able to build for node using
commons,esm, and building for the browser without the need for aliases.