Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To remove annoying error logs at shutdown we added a
Amqpx.DirectConsumer
module to implement the:amqp_gen_consumer
behaviour reusing (throughdefdelegate
) all:amqp_direct_consumer
code except for thehandle_info
function where we added two pattern matches to handle the:shutdown
exit reasons as normal, expected occurrences.We tested the solution running the
test/gen_test.exs
suite and those pesky error logs disappeared; being certain of anything is quite hard with this lib though cause tests, in general, are pretty flaky.We may want to test the implementation in a non critical project of ours before creating a new release