Fix connection manager #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/amqp/gen/connection_manager.ex
Outdated
| @@ -65,13 +64,15 @@ defmodule Amqpx.Gen.ConnectionManager do | |||
|
|
|||
| def terminate(_, %__MODULE__{connection: connection}) do | |||
| if Process.alive?(connection.pid) do | |||
| Process.exit(connection.pid, :kill) | |||
| Connection.close(connection) | |||
There was a problem hiding this comment.
I saw that Connection.close could return an error. It's true that here we are inside a terminate function and there's not so much we can do, but maybe it could be worthwhile to add a log for that scenario, WDYT?
PaoloLaurenti
approved these changes
May 21, 2024
cpiemontese
approved these changes
May 22, 2024
succoDiPompelmo
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ConnectionManager module was implementing the GenServer behaviour, with a proper terminate/2 function but it wasn't trapping exits so the terminate wasn't being called (ever). Moreover, it was abrutly closing the connection with an exit/2 call instead of using the proper function.