Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Focus on the first suggestion in MultiSelect filter (#16728) #16786

Closed
wants to merge 10 commits into from
Closed

Fix: Focus on the first suggestion in MultiSelect filter (#16728) #16786

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e016ca3
Create npm-grunt.yml
mateuszstudentzero Oct 16, 2024
5016e36
create an index.html file
mateuszstudentzero Oct 16, 2024
17c8228
Update index.html
mateuszstudentzero Oct 16, 2024
a537ea0
Update index.html
mateuszstudentzero Oct 16, 2024
c86d1c5
Merge branch 'primefaces:master' into master
mateuszstudentzero Oct 17, 2024
64cc282
Fix autoOptionFocus to focus the first option in MultiSelect filter
Nov 20, 2024
0ce1531
Merge branch 'primefaces:master' into fix/16728-clean
joaanyk Nov 20, 2024
3a833be
Remove unnecessary files: npm-grunt.yml and index.html
Nov 20, 2024
528d0c7
Remove unnecessary blank spaces
Nov 20, 2024
bad1480
Fix code formatting issues
Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions src/app/components/multiselect/multiselect.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1769,19 +1769,22 @@ export class MultiSelect implements OnInit, AfterViewInit, AfterContentInit, Aft
event.preventDefault();
}

onEnterKey(event) {
onEnterKey(event: KeyboardEvent) {
if (!this.overlayVisible) {
this.onArrowDownKey(event);
this.show(true);
this.focusedOptionIndex.set(this.findFirstFocusedOptionIndex());
} else {
if (this.focusedOptionIndex() !== -1) {
if (event.shiftKey) {
this.onOptionSelectRange(event, this.focusedOptionIndex());
} else {
this.onOptionSelect({ originalEvent: event, option: this.visibleOptions()[this.focusedOptionIndex()] });
const selectedOption = this.visibleOptions()[this.focusedOptionIndex()];
this.onOptionSelect({ originalEvent: event, option: selectedOption });
}
} else {
console.warn('No option is currently focused to select.');
}
}

event.preventDefault();
}

Expand Down Expand Up @@ -1873,13 +1876,13 @@ export class MultiSelect implements OnInit, AfterViewInit, AfterContentInit, Aft
onFilterInputChange(event: KeyboardEvent) {
let value: string = (event.target as HTMLInputElement).value;
this._filterValue.set(value);
this.focusedOptionIndex.set(-1);
this.onFilter.emit({ originalEvent: event, filter: this._filterValue() });

!this.virtualScrollerDisabled && this.scroller.scrollToIndex(0);
setTimeout(() => {
this.overlayViewChild.alignOverlay();
});
if (this.autoOptionFocus && this.visibleOptions().length > 0) {
this.focusedOptionIndex.set(0);
} else {
this.focusedOptionIndex.set(-1);
}
this.onFilter.emit({ originalEvent: event, filter: this._filterValue() });
}

onLastHiddenFocus(event) {
Expand Down