Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#15009 bug with not contains #16853

Open
wants to merge 7 commits into
base: v18-prod
Choose a base branch
from

Conversation

juri-sinitson
Copy link

Defect Fixes

Fixes the #15009 and adding unit tests for filtering.
Feel free to modify my code before merging when necessary.

Additionally move the filter method there
NOTE:
1. Configured jest according to https://thymikee.github.io/jest-preset-angular/docs/getting-started/installation
2. In was recommended in diverse sources to comment out the files
in `tsconfig.spec.json` to avoid conflicts with jest
- Especially the fixing the global filter `notContains`
which is the main scope of this issue.
Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Nov 26, 2024 2:46pm
primeng-v18 ⬜️ Ignored (Inspect) Visit Preview Nov 26, 2024 2:46pm

@juri-sinitson
Copy link
Author

Remarks

  1. I've covered the whole filter method of TableService method and the most of the FilterService
  2. Maybe it's reasonable to link the unit tests of TableService to the documentation of the table filtering

@juri-sinitson
Copy link
Author

Also let me know, if need to change something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant