Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refact] Add Ser/De Trait #256

Merged
merged 4 commits into from
Jan 13, 2024
Merged

[Refact] Add Ser/De Trait #256

merged 4 commits into from
Jan 13, 2024

Conversation

Lzzzzzt
Copy link
Contributor

@Lzzzzzt Lzzzzzt commented Jan 5, 2024

Add A Trait to abstract the serialize_* and deserialize_* functon
Pass all the test

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 46 lines in your changes are missing coverage. Please review.

Comparison is base (bdec65a) 83.27% compared to head (1d8e615) 83.28%.

Files Patch % Lines
core/src/ast.rs 60.00% 12 Missing ⚠️
core/src/scope.rs 16.66% 10 Missing ⚠️
core/src/num/continued_fraction.rs 25.00% 9 Missing ⚠️
core/src/value.rs 82.05% 7 Missing ⚠️
core/src/num/unit.rs 93.65% 4 Missing ⚠️
core/src/serialize.rs 94.11% 2 Missing ⚠️
core/src/date.rs 87.50% 1 Missing ⚠️
core/src/num/formatting_style.rs 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #256      +/-   ##
==========================================
+ Coverage   83.27%   83.28%   +0.01%     
==========================================
  Files          52       52              
  Lines       14468    14547      +79     
==========================================
+ Hits        12048    12116      +68     
- Misses       2420     2431      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@printfn
Copy link
Owner

printfn commented Jan 13, 2024

Thanks for your pull request!

@printfn printfn merged commit 58136e4 into printfn:main Jan 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants