Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to enter the password for the live tracking MQTT broker #669

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Add option to enter the password for the live tracking MQTT broker #669

merged 1 commit into from
Oct 7, 2024

Conversation

adeveloper-wq
Copy link
Member

@adeveloper-wq adeveloper-wq commented Oct 4, 2024 •
edited
Loading

If available, link to the ticket

Closes: /

QA Checklist

Author

  • Code Review
  • Functionality Tested (iOS and Android + different screens)
  • Light/Dark Mode Tested
  • Performance/Energy Consumption Tested (especially in ride view)

Reviewer

  • Code Review
  • Functionality Tested (iOS and Android + different screens)
  • Light/Dark Mode Tested
  • Performance/Energy Consumption Tested (especially in ride view)

@adeveloper-wq
Copy link
Member Author

Can you test on Android? @PaulPickhardt

PaulPickhardt
PaulPickhardt approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@PaulPickhardt PaulPickhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works on android as well

@adeveloper-wq adeveloper-wq merged commit d58bb7b into dev Oct 7, 2024
1 check passed
@adeveloper-wq adeveloper-wq deleted the feature/live-tracking-mqtt-password branch October 7, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulPickhardt PaulPickhardt PaulPickhardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adeveloper-wq @PaulPickhardt