This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
Duplicate imports generated when overrides export an interface with the same name #340
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if two or more overrides each export an interface with the same name, duplicate imports are generated. I added a test that demonstrates this: https://github.com/prisma/graphqlgen/compare/master...apalm:override-model-dupes?expand=1#diff-f86c01cb4fc0fd4ae178ca2f4527a870R1767.
I have a (rough) fix for this locally, by aliasing the imports, but before iterating further, I wanted to confirm that overrides that export interfaces with the same name should be supported, and that the current behavior is a bug.