-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: target platform e2e #3340
Conversation
770cdef
to
e749006
Compare
e749006
to
b61b560
Compare
- name: Set up QEMU | ||
uses: docker/setup-qemu-action@v2 | ||
with: | ||
platforms: "arm64" | ||
|
||
- name: Set up Docker Buildx | ||
id: buildx | ||
uses: docker/setup-buildx-action@v2 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add multiarchitecture support (amd64
, arm64
)
# Add back once we solve https://github.com/prisma/prisma-private/issues/205 | ||
# - debian-latest-arm64-openssl-1.1.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could also have it before we fix it? (it would fail, but we'll instantly know once it's fixed)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could, but I'd be wary of merging something that results in a red CI status
Note: change base to |
…m-tests into feat/target-platform-e2e
RUN ./uname.sh | ||
|
||
# Only OpenSSL 1.1 is expected to be on this system | ||
RUN ldconfig -p | grep ssl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RUN ldconfig -p | grep ssl | |
RUN ldconfig -p | grep ssl | sed "s/.*=>\s*//" |
Missing or intentional?
|
||
FROM ubuntu:${UBUNTU_VERSION} | ||
|
||
ARG NODE_VERSION="18.12.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discussed that this could use the most recent LTS version and that we could have a test for the latest version too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Easy way would be to replace with https://github.com/nodesource/distributions
Node.js LTS (v18.x):
Using Ubuntu
curl -fsSL https://deb.nodesource.com/setup_lts.x | sudo -E bash - &&\
sudo apt-get install -y nodejs
Using Debian, as root
curl -fsSL https://deb.nodesource.com/setup_lts.x | bash - &&\
apt-get install -y nodejs
Node.js Current (v19.x):
Using Ubuntu
curl -fsSL https://deb.nodesource.com/setup_current.x | sudo -E bash - &&\
sudo apt-get install -y nodejs
Using Debian, as root
curl -fsSL https://deb.nodesource.com/setup_current.x | bash - &&\
apt-get install -y nodejs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I checked the logs and everything seems to work like expected there 💯
We discussed we don't want to merge this PR because it's based on latest
branch and we want to merge to dev
.
Closing this in favor of #3341. |
Contributes to prisma/prisma#14017, #3332, prisma/prisma#16962, prisma/docs#4303
This PR adds Dockerised OS Support tests for in the
./docker
folder. In particular, it tries to run Prisma Client (both binary and library) in the following systems:Additionally, for each Dockerised system, we assert the
binaryTarget
selected by Prisma (i.e., theCurrent platform
value inprisma -v
). If a major Docker image suddenly introduces a new OpenSSL version we don't support, or switches to another architecture by default, we will receive a Slack notification.Multiarchitecture support (
amd64
,arm64
) works via QEMU (docker/setup-qemu-action@v2
) and Docker Buildx (docker/setup-buildx-action@v2
).Review Helpers
.yaml
,.sh
No extension
.md
.md
,.yaml
,.sh
,No extension
TODOs
From these tests, I have opened the following issues:
We should:
debian-latest-arm64-openssl-1.1.x
to the Docker test pipeline once https://github.com/prisma/prisma-private/issues/205 is solved.docker
workflow only once per day_fail-debian-buster-amd64-openssl-1.1.x