Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tech(LS): moving hover functionality to engines #1766

Merged
merged 9 commits into from
Jul 11, 2024
Merged

tech(LS): moving hover functionality to engines #1766

merged 9 commits into from
Jul 11, 2024

Conversation

Druue
Copy link
Contributor

@Druue Druue commented Jun 17, 2024

This is a companion to this engines PR:
prisma/prisma-engines#4923

@Druue Druue self-assigned this Jul 4, 2024
@Druue Druue marked this pull request as ready for review July 5, 2024 10:48
@Druue Druue added this to the 5.17.0 milestone Jul 5, 2024
@Druue
Copy link
Contributor Author

Druue commented Jul 10, 2024 •
edited
Loading

https://github.com/prisma/prisma-engines/actions/runs/9874337903
waiting for this to

  1. hit engines-wrapper

  1. get published to npm

  2. pulled into LT main

@Druue Druue requested a review from SevInf July 11, 2024 10:26
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 11, 2024 •
edited
Loading

🤖 Pull request artifacts

empty string

file commit
prisma.vsix 084c897

github-actions bot added a commit that referenced this pull request Jul 11, 2024
@github-actions
Upload pull-request-artifacts/pr1766-prisma.vsix (17838)
8cfa918 
Pull request: #1766
Commit: 1783889
@github-actions GitHub Actions
Copy link

Try this extension build via GitPod

github-actions bot added a commit that referenced this pull request Jul 11, 2024
@github-actions
Upload pull-request-artifacts/pr1766-prisma.vsix (b0c7e)
14fb945 
Pull request: #1766
Commit: b0c7e00
github-actions bot added a commit that referenced this pull request Jul 11, 2024
@github-actions
Upload pull-request-artifacts/pr1766-prisma.vsix (35c83)
222b966 
Pull request: #1766
Commit: 35c8381
SevInf
SevInf approved these changes Jul 11, 2024
View reviewed changes
Copy link

@SevInf SevInf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nit

github-actions bot added a commit that referenced this pull request Jul 11, 2024
@github-actions
Upload pull-request-artifacts/pr1766-prisma.vsix (084c8)
2e025dd 
Pull request: #1766
Commit: 084c897
@Druue Druue merged commit 20b25b1 into main Jul 11, 2024
7 checks passed
@Druue Druue deleted the feat/hover branch July 11, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SevInf SevInf SevInf approved these changes

Assignees

@Druue Druue

Labels
None yet
Projects
None yet
Milestone
5.17.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Druue @SevInf