Resolve issues when installing the Prisma client in a PNPM workspace using Nuxt layers

[Dobefu]

This PR will fix #29

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nuxt-prisma	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 30, 2024 2:33pm

[Dobefu]

Please note: on this version of the PR, installation will happen in the wrong Nuxt layer. A workaround for now is to manually install the client and set the installPrismaClient option to false.
I do not have much time to look into this further for a couple of days, so I hope this is a helpful start at least.

[Dobefu]

I'm back!

@ankur-arch I would like to add two configuration options, but I'd like your thoughts on it:

• packageManager
  • Will allow users to skip the whole filesystem checks, and is less error-prone
  • This will be optional, and fall back to the current detection method
• prismaRoot
  • Will allow users to customise where Prisma does its thing
  • Will resolve Usage with a layer based architecture #16
  • Will resolve Package manager cannot get resolved when using Nuxt Layers #29
  • Will probably resolve Failed on initial start (bun) #31

I think especially the second option would benefit a lot of people, since I don't see a way that we can detect it in the code in a reliable and performant manner.

[ankur-arch]

Thanks @Dobefu! I'll check on this the next week as I'm on limited availability this week.

[husayt]

@ankur-arch will be really nice if this could be checked. Many users of nuxt-prisma are using layers and if already there is a solution to this issue, why not to use it.

[husayt]

@ankur-arch will be really nice if this could be checked. Many users of nuxt-prisma are using layers and if already there is a solution to this issue, why not to use it.

Just to check if the issue I had was related to this and not something else, I switched to npm and it worked. So it was definetely caused by lack of pnpm support. Switching to npm can be a workaround for now

[ankur-arch]

Hey @Dobefu 👋,

This has been in draft for a while, so I wanted to check in to see if you’re planning to get to this. Thanks for your contributions so far—they’ve been really valuable 🔥 !

Let me know if you’re planning to pick this up; otherwise, I’ll move forward with the updates to ensure compatibility with other package managers and Nuxt layers, as I’d like to proceed soon.

Looking forward to hearing from you and possibly collaborating again 😄 !

[Dobefu]

Hi @ankur-arch!

I'm certainly open to collaborate again!

To be quite honest, I was waiting for your thoughts on #30 (comment) and then proceeded to... kind of forget to follow up on it 😅. My apologies. What are your thoughts on the configuration options in my previous comment? If they're alright to add, I can look into it this weekend.

[Dobefu]

Alrighty, I've fixed the merge conflicts.
I've tested it, and I believe that the PR is pretty much ready to be reviewed.
I'll just assume that the two extra options are fine 🙂

[Dobefu]

Hi @ankur-arch,

Have you had time to look into this, yet?
A CI task has failed, but as far as I can see, this might be because of permissions on my end. It shouldn't be related to my changes at all, unless I'm mistaken.

[ankur-arch]

Hey @Dobefu 👋 ,

I apologize for my recent absence; I've been busy with other commitments. It's great to have you back, and I really appreciate you taking the time to work on this PR and resolve the merge conflicts.

Have you had time to look into this, yet?
I noticed one of the CI tasks failed. From what I can tell, this seems to be related to permission issues on my end rather than any changes in the PR.

Since this PR is from a fork, GitHub won't allow the preview package to be published through the workflow, so I'll need to test it manually.

I'll just assume that the two extra options are fine 🙂

The options look good to me!

I'll test the PR tomorrow and then proceed with merging it. I'll also review any accompanying documentation changes to ensure everything is consistent.

[ankur-arch]

Hey @Dobefu 👋,

I gave the PR a try and still have a few tests left to go. Sorry for the delay—I'll wrap it up on Monday! 😊