test: run query engine tests with query compiler #5146
+2,382
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #5146 will not alter performanceComparing Summary
|
WASM Query Engine file Size
|
aqrln
force-pushed
the
push-qrnvpsponvyr
branch
16 times, most recently
from
22900bc to
f9fd55e
Compare
aqrln
force-pushed
the
push-qrnvpsponvyr
branch
from
f9fd55e to
a41edef
Compare
aqrln
force-pushed
the
push-qoyxpstyypys
branch
from
d157164 to
c468ec2
Compare
aqrln
force-pushed
the
push-qrnvpsponvyr
branch
from
a41edef to
e212505
Compare
aqrln
force-pushed
the
push-qoyxpstyypys
branch
from
c468ec2 to
eaefcbd
Compare
aqrln
force-pushed
the
push-qrnvpsponvyr
branch
from
e212505 to
3f14267
Compare
aqrln
force-pushed
the
push-qoyxpstyypys
branch
from
eaefcbd to
ffebe63
Compare
aqrln
force-pushed
the
push-qrnvpsponvyr
branch
2 times, most recently
from
0f58c9e to
c462b32
Compare
aqrln
force-pushed
the
push-qrnvpsponvyr
branch
from
c462b32 to
e0162d2
Compare
aqrln
force-pushed
the
push-qrnvpsponvyr
branch
13 times, most recently
from
6251de8 to
5d29f7f
Compare
aqrln
force-pushed
the
push-qrnvpsponvyr
branch
2 times, most recently
from
6847763 to
17710bb
Compare
aqrln
commented
Feb 10, 2025
| type: 'teardown', | ||
| }) | ||
|
|
||
| await schemaState.worker.terminate() |
aqrln
commented
Feb 10, 2025
| .await | ||
| .unwrap(); | ||
| if let Err(e) = teardown_project(&datamodel, Default::default(), runner.schema_id()).await { | ||
| if !expected_to_fail { |
aqrln
commented
Feb 10, 2025
| Ok::<(), TestError>(()) | ||
| } | ||
| Err(_) => { | ||
| eprintln!("test panicked as expected"); |
There was a problem hiding this comment.
downcast the panic and print the message
aqrln
force-pushed
the
push-qrnvpsponvyr
branch
2 times, most recently
from
62973b5 to
e7d5972
Compare
aqrln
force-pushed
the
push-qrnvpsponvyr
branch
from
e7d5972 to
1dfe965
Compare
Comment on lines
+380
to
+381
| let last = parts.len() - 1; | ||
| parts[last] = original_test_function_name; |
There was a problem hiding this comment.
Suggested change
| let last = parts.len() - 1; | |
| parts[last] = original_test_function_name; | |
| parts.pop(); | |
| parts.push(original_test_function_name); |
I like to avoid index arithmetic when possible
Comment on lines
+8
to
+9
| static IGNORED_TESTS: OnceLock<Vec<String>> = OnceLock::new(); | ||
| static SHOULD_FAIL_TESTS: OnceLock<Vec<String>> = OnceLock::new(); |
| @@ -60,6 +60,9 @@ build() { | |||
| local CONNECTOR="$1" | |||
| local CARGO_TARGET_DIR | |||
| CARGO_TARGET_DIR=$(cargo metadata --format-version 1 | jq -r .target_directory) | |||
|
|
|||
| export RUSTFLAGS="-C link-args=-zstack-size=16777216" | |||
There was a problem hiding this comment.
might be worth leaving a comment why we set the stack size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: https://linear.app/prisma-company/issue/ORM-555/make-prisma-engines-tests-run-with-query-compiler