fix(adapter-planetscale): Use instanceof for checking for Client instance
#21939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stance Prevoulsly, we tried to check for constructor name, which theoretically should've been more reliable and work with several copies of `@planetscale/database`. However, name gets mangled during minification and check fails. Since minification is pretty common usecase (unlike having multiple copies of the `@planetscale/database`), reverting back to `instanceof` check.
size-limit report 📦
|
|
Note: found via prisma/ecosystem-tests#4226 |
Jolg42
reviewed
Nov 14, 2023
Jolg42
reviewed
Nov 14, 2023
Jolg42
approved these changes
Nov 14, 2023
janpio
requested review from
a team,
aqrln and
jkomyno
and removed request for
a team
added 2 commits
November 14, 2023 10:48
|
Heya, this has caused some issues (#21956) for me :/ |
|
Thanks! Let's continue the discussion in #21956 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevoulsly, we tried to check for constructor name, which theoretically
should've been more reliable and work with several copies of
@planetscale/database. However, name gets mangled during minificationand check fails. Since minification is pretty common usecase (unlike
having multiple copies of the
@planetscale/database), reverting backto
instanceofcheck.