srcurifile: skip inline blocks

Closes #465 Signed-off-by: Konrad Weihmann <[email protected]>
priv-kweihmann · Jan 4, 2024 · eb99acc · eb99acc
1 parent 478c200
commit eb99acc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/oelint_adv/rule_base/rule_var_src_uri_file.py b/oelint_adv/rule_base/rule_var_src_uri_file.py
@@ -29,6 +29,6 @@ def check(self, _file, stash):
                 if _url['scheme']:
                     _fetcher.append((_url['scheme'], item.InFileLine))
         if _fetcher:
-            if any(x[0] != 'file' for x in _fetcher) and _fetcher[0][0] == 'file':
+            if any(x[0] not in ['file', 'inline'] for x in _fetcher) and _fetcher[0][0] == 'file':
                 res += self.finding(item.Origin, _fetcher[0][1])
         return res
diff --git a/tests/test_class_oelint_vars_srcurifile.py b/tests/test_class_oelint_vars_srcurifile.py
@@ -57,7 +57,11 @@ def test_bad(self, input_, id_, occurrence):
                                  },
                                  {
                                      'oelint_adv_test.bb':
-                                     'SRC_URI[md5sum] = "file://abc"',
+                                     'SRC_URI += "file://abc"',
+                                 },
+                                 {
+                                     'oelint_adv_test.bb':
+                                     'SRC_URI = "file://foo ${@bb.utils.contains(\'FOO\', \'bar\', \'file://bar\', \'\', d)}"',
                                  },
                                  {
                                      'oelint_adv_test.bb':