Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task.docstrings: skip for __anonymous tasks #475

Merged
merged 4 commits into from
Jan 6, 2024
Merged

task.docstrings: skip for __anonymous tasks #475

merged 4 commits into from
Jan 6, 2024

Conversation

priv-kweihmann
Copy link
Owner

Closes #474

Pull request checklist

Bugfix

  • A testcase was added to test the behavior

New feature

  • A testcase was added to test the behavior
  • New functions are documented with docstrings
  • No debug code is left
  • README.md was updated to reflect the changes (check even if n.a.)

Signed-off-by: Konrad Weihmann <[email protected]>
@priv-kweihmann priv-kweihmann force-pushed the fixes branch 4 times, most recently from 888c57b to ccf84da Compare January 6, 2024 13:22
- avoid multiple calls to stash.GetItemsFor
- pre-filter items as much as possible
- call parser functions only once for static items
  (e.g. get_valid_package_names)
- use sets if appropriate

Closes #476

Signed-off-by: Konrad Weihmann <[email protected]>
as the rule applies to all package names, not just only PN.
As this rule is also triggered when the used package is unknown,
we should make that more clear.
Also use the valid override delimiter found in the stash
instead of printing old and new syntax

Signed-off-by: Konrad Weihmann <[email protected]>
@priv-kweihmann priv-kweihmann merged commit 70b3c6e into master Jan 6, 2024
5 checks passed
@priv-kweihmann priv-kweihmann deleted the fixes branch January 6, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

oelint.task.docstrings for __anonymous tasks
1 participant