Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bugs and improvements on the docker image #18

Merged
merged 9 commits into from
Jan 13, 2025
Merged

Conversation

saravahdatipour
Copy link
Contributor

No description provided.

README.markdown Outdated Show resolved Hide resolved
w-ensink
w-ensink previously approved these changes Jan 13, 2025
w-ensink
w-ensink previously approved these changes Jan 13, 2025
Copy link

@jappe999 jappe999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know for sure if setting the server name to 127.0.0.1 will accept requests from external hosts (e.g. attributes.yivi.app)

nginx.conf Outdated Show resolved Hide resolved
w-ensink
w-ensink previously approved these changes Jan 13, 2025
@saravahdatipour saravahdatipour marked this pull request as draft January 13, 2025 10:13
@saravahdatipour saravahdatipour marked this pull request as ready for review January 13, 2025 10:30
Copy link

@jappe999 jappe999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🙌

@saravahdatipour saravahdatipour merged commit c0e8072 into master Jan 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants