Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Peergos in Cloud Storage section #2429

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Add Peergos in Cloud Storage section #2429

merged 1 commit into from
Apr 2, 2024

Conversation

rollsicecream
Copy link
Contributor

@rollsicecream rollsicecream commented Mar 8, 2024 •
edited
Loading

Changes proposed in this PR:

  • Add Peergos in the Cloud Storage and Productivity section

https://discuss.privacyguides.net/t/peergos-private-storage-sharing-social-media-and-application-platform/11825

@ianopolous If you want something to be changed, don't hesitate to reach me out!

  • I have disclosed any relevant conflicts of interest in my post.
  • I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project.
  • I am the sole author of this work.
  • I agree to the Community Code of Conduct.

@netlify Netlify
Copy link

netlify bot commented Mar 8, 2024 •
edited
Loading

👷 Deploy Preview for privacyguides processing.

Name Link
🔨 Latest commit aec781c
🔍 Latest deploy log https://app.netlify.com/sites/privacyguides/deploys/6605d9ad99c702000759dec6

@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/peergos-private-storage-sharing-social-media-and-application-platform/11825/46

@rollsicecream rollsicecream force-pushed the peergos branch 2 times, most recently from 7e41d4e to 75d8e3d Compare March 8, 2024 12:38
@dngray dngray added the c:providers service providers and similar centralized/federated services label Mar 9, 2024
@rollsicecream
Copy link
Contributor Author

Just fixed a merge conflict.

@ianopolous
Copy link

Looks great to me! Thank you @rollsicecream

@rollsicecream rollsicecream changed the title Add Peergos in Cloud Storage section Add Peergos in Cloud Storage and Productivity section Mar 9, 2024
@dngray dngray force-pushed the peergos branch 2 times, most recently from f404808 to 4e3e552 Compare March 13, 2024 05:47
@rollsicecream rollsicecream force-pushed the peergos branch 2 times, most recently from 4785562 to 499af76 Compare March 13, 2024 14:42
@rollsicecream
Copy link
Contributor Author

@dngray It can now be merged.

@dngray
Copy link
Member

dngray commented Mar 13, 2024 •
edited
Loading

@dngray It can now be merged.

Not sure what you changed, i fixed merge conflict and rebased on master/replaced svg

There was no copy in cloud.md

Did you forget to pull before making changes?

@rollsicecream
Copy link
Contributor Author

Did you forget to pull before making changes?

Yeah.... You're right. I should have better Git habits lol

dngray pushed a commit to rollsicecream/privacyguides-fork that referenced this pull request Mar 13, 2024
@rollsicecream @dngray
Add Peergos to Productivity/Cloud section (privacyguides#2429)
33931cf
dngray pushed a commit to rollsicecream/privacyguides-fork that referenced this pull request Mar 16, 2024
@rollsicecream @dngray
Add Peergos to Productivity/Cloud section (privacyguides#2429)
18a9536 
Signed-off-by: Daniel Gray <[email protected]>
dngray pushed a commit to rollsicecream/privacyguides-fork that referenced this pull request Mar 16, 2024
@rollsicecream @dngray
Add Peergos to Productivity/Cloud section (privacyguides#2429)
39e548c 
Signed-off-by: Daniel Gray <[email protected]>
@rollsicecream
Copy link
Contributor Author

Any updates?

jonaharagon
jonaharagon requested changes Mar 28, 2024
View reviewed changes
Copy link
Member

@jonaharagon jonaharagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't meet https://www.privacyguides.org/en/productivity/#criteria

jonaharagon
jonaharagon requested changes Mar 28, 2024
View reviewed changes
Copy link
Member

@jonaharagon jonaharagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rollsicecream! Just want to collect thoughts on a couple things below before merging.

docs/cloud.md Outdated Show resolved Hide resolved
docs/cloud.md Outdated Show resolved Hide resolved
docs/cloud.md Outdated Show resolved Hide resolved
docs/cloud.md
Comment on lines +106 to +108
- [:simple-windows11: Windows](https://github.com/Peergos/web-ui/releases)
- [:simple-apple: macOS](https://github.com/Peergos/web-ui/releases)
- [:simple-linux: Linux](https://github.com/Peergos/web-ui/releases)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of curious whether we think a single :material-language-java: Java download link makes more sense for Java applications like this, since they are inherently cross-platform, and they require a separate runtime environment, so it's almost its own platform itself. Thoughts?

  • Pro: Readers can immediately tell that something will require a separate Java install and won't just run natively.
  • Con: Not sure if everyone will read "Java" and understand it will probably work regardless of OS. Is that common knowledge among average computer-using adults? Feels like it might be because of e.g. games like Minecraft, but idk.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have previously had static native builds for each platform there as well, and we hope to return to that in either the next release or the one after. I think requiring most people to install java is too much.

@jonaharagon jonaharagon force-pushed the main branch 15 times, most recently from e124ecf to 82ab189 Compare March 31, 2024 09:04
@dngray
Copy link
Member

dngray commented Apr 2, 2024

@dngray lmk what you think about #2429 (comment) and if we don't want to change anything I'm good to merge this.

If they're going to return next build them I'm happy to leave as is.

@ianopolous
Copy link

I think there might be a dangling link to productivity in tools.md?

@dngray
Copy link
Member

dngray commented Apr 2, 2024

I think there might be a dangling link to productivity in tools.md?

Yes giving this another look over now.

@dngray dngray changed the title Add Peergos in Cloud Storage and Productivity section Add Peergos in Cloud Storage section Apr 2, 2024
dngray pushed a commit to rollsicecream/privacyguides-fork that referenced this pull request Apr 2, 2024
@rollsicecream @dngray
Add Peergos to Cloud section (privacyguides#2429)
4ce7420 
Signed-off-by: Daniel Gray <[email protected]>
Signed-off-by: Jonah Aragon <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2024 •
edited
Loading

✅ Your preview is ready!

Name Link
🔨 Latest commit 04c37b9
😎 Preview

dngray pushed a commit to rollsicecream/privacyguides-fork that referenced this pull request Apr 2, 2024
@rollsicecream @dngray
Add Peergos to Cloud section (privacyguides#2429)
e090992 
Signed-off-by: Daniel Gray <[email protected]>
Signed-off-by: Jonah Aragon <[email protected]>
@rollsicecream @dngray
Add Peergos to Cloud section (privacyguides#2429)
04c37b9 
Signed-off-by: Daniel Gray <[email protected]>
Signed-off-by: Jonah Aragon <[email protected]>
@dngray dngray merged commit 04c37b9 into privacyguides:main Apr 2, 2024
12 checks passed
@rollsicecream rollsicecream deleted the peergos branch April 6, 2024 12:28
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/2024-04-08/17760/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianopolous ianopolous ianopolous left review comments

@dngray dngray dngray approved these changes

@jonaharagon jonaharagon jonaharagon approved these changes

@freddy-m freddy-m Awaiting requested review from freddy-m

Assignees
No one assigned
Labels
c:providers service providers and similar centralized/federated services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rollsicecream @privacyguides-bot @ianopolous @dngray @jonaharagon