Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update size requirements for company logos #2808

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

friadev
Copy link
Contributor

@friadev friadev commented Nov 12, 2024

List of changes proposed in this PR:

  • Removed the size recommendation for company logos on the Uploading Images page since they'll just be resized anyway, better to have the original version (after optimization)

Copy link

github-actions bot commented Nov 12, 2024

Your preview is ready!

Name Link
🔨 Latest commit e6bedf1
😎 Preview https://pr2808.unreviewed.privacyguides.dev/en/

@friadev friadev marked this pull request as ready for review November 12, 2024 04:17
@jonaharagon
Copy link
Member

better to have the original version

There's no difference for SVG files.

Actually we should add a note that PNGs should always be at least 200x200, because logo images display at 100x100 and we want them looking good on 2x retina displays.

@friadev friadev changed the title update: Remove Size from Company Logos update: Update size requirements for company logos Nov 13, 2024
@redoomed1 redoomed1 changed the title update: Update size requirements for company logos docs: Update size requirements for company logos Nov 14, 2024
@redoomed1 redoomed1 added the m:contributing relating to contributing/community label Nov 14, 2024
@jonaharagon jonaharagon merged commit e6bedf1 into privacyguides:main Nov 14, 2024
6 checks passed
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides Community. There might be relevant details there:

https://discuss.privacyguides.net/t/2024-11-14/22431/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
m:contributing relating to contributing/community
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants