Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update(blog)!: Where are all the Multi-Party Relays? #2813

Merged
merged 1 commit into from
Nov 17, 2024
Merged

update(blog)!: Where are all the Multi-Party Relays? #2813

merged 1 commit into from
Nov 17, 2024

Conversation

friadev
Copy link
Contributor

@friadev friadev commented Nov 13, 2024

List of changes proposed in this PR:

  • added an article wrote to the blog

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 13, 2024 •
edited
Loading

✅ Your preview is ready!

Name Link
🔨 Latest commit 1712b74
😎 Preview https://pr2813.unreviewed.privacyguides.dev/en/

Please note that this preview was built from an untrusted source, so it was not granted access to all mkdocs-material features.
Maintainers should ensure this PR has been reviewed locally with a full build before merging.

@friadev friadev added ci:build blog Enable blog builds on a PR c:blog relating to privacyguides.org/blog labels Nov 13, 2024
@jonaharagon jonaharagon changed the title update!: Add article on MPRs update(blog)!: Add article on MPRs Nov 14, 2024
@friadev friadev marked this pull request as ready for review November 15, 2024 22:14
jonaharagon
jonaharagon reviewed Nov 15, 2024
View reviewed changes
Copy link
Member

@jonaharagon jonaharagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll wait to approve until I get back to my laptop and can review it more thoroughly (and fix the blog builds on forks), but reading on my phone I really like this post and it LGTM 👍

jonaharagon
jonaharagon requested changes Nov 16, 2024
View reviewed changes
Copy link
Member

@jonaharagon jonaharagon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened friadev#1 with suggested changes.

I don't think anything in my suggestions should change the meaning of the content, it was mainly just that I wanted to rearrange some of the sections, which was too annoying to do with GitHub web comments.

edit: also to add some graphics

redoomed1
redoomed1 reviewed Nov 16, 2024
View reviewed changes
Copy link
Member

@redoomed1 redoomed1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the intro, all of my suggestions are minor. No notes about the content, since the article is already super clear and digestible.

blog/posts/where-are-all-the-mprs.md Outdated Show resolved Hide resolved
blog/posts/where-are-all-the-mprs.md Outdated Show resolved Hide resolved
blog/posts/where-are-all-the-mprs.md Outdated Show resolved Hide resolved
blog/posts/where-are-all-the-mprs.md Outdated Show resolved Hide resolved
blog/posts/where-are-all-the-mprs.md Outdated Show resolved Hide resolved
blog/posts/where-are-all-the-mprs.md Outdated Show resolved Hide resolved
blog/posts/where-are-all-the-mprs.md Outdated Show resolved Hide resolved
blog/posts/where-are-all-the-mprs.md Outdated Show resolved Hide resolved
jonaharagon
jonaharagon approved these changes Nov 16, 2024
View reviewed changes
Copy link
Member

@jonaharagon jonaharagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you could review the other suggestions here too then I'll merge this today 👍

redoomed1
redoomed1 approved these changes Nov 17, 2024
View reviewed changes
Copy link
Member

@redoomed1 redoomed1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

blog/posts/where-are-all-the-mprs.md Outdated Show resolved Hide resolved
@jonaharagon jonaharagon changed the title update(blog)!: Add article on MPRs update(blog)!: Where are all the Multi-Party Relays? Nov 17, 2024
@jonaharagon jonaharagon merged commit 37a938b into privacyguides:main Nov 17, 2024
9 checks passed
@friadev friadev deleted the pr-blogpost branch November 17, 2024 09:02
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides Community. There might be relevant details there:

https://discuss.privacyguides.net/t/2024-11-17/22510/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redoomed1 redoomed1 redoomed1 approved these changes

@jonaharagon jonaharagon jonaharagon approved these changes

@dngray dngray Awaiting requested review from dngray dngray is a code owner

@freddy-m freddy-m Awaiting requested review from freddy-m freddy-m is a code owner

Assignees
No one assigned
Labels
c:blog relating to privacyguides.org/blog ci:build blog Enable blog builds on a PR
Projects
PR Review Status
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@friadev @privacyguides-bot @jonaharagon @redoomed1