-
-
Notifications
You must be signed in to change notification settings - Fork 385
Add info tooltip for BitWarden to recommend registering through desktop clients #2329
base: master
Are you sure you want to change the base?
Conversation
…op clients than the website Signed-off-by: Stephen L. <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I don't understand that point. |
It's not bitwarden the issue but keyloggers in malicious browser's
extensions for example. But yes i should also add sign is using app or
extension, thank you for the suggestion.
Le mer. 9 juin 2021 à 02:19, youdontneedtoknow22 ***@***.***>
a écrit :
… I don't understand that point.
Bitwarden would use a malicious javascript to get the account password
from someone signing IN, because he could have some important passwords
saved.
But to sign UP using the client, is not important because you already
don't have passwords in your account, you're about to make an account.
So the info added should be: Avoid signin in your Bitwared account using
the browser. Sign up, set up your 2FA and never sign in again. Or am I
missing something?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2329 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIRFXVUPRJJ63RVW4AUGETTR2XSLANCNFSM457AJC7A>
.
|
If the Issue is a keylogger inside the browser, then the whole discussion with the jurisdiction of Bitwarden isn't relevant any more. I believe our friend there was refering to Bitwarden using a malicious javascript to steal the login information for a specific user, done by bitwarden. US Companies maybe forced to do such thing (Lavabit and Snowden Story) Tbh I'm neither familiar with Keyloggers inside browser's addons nor Bitwarden (I use KeypassXC and Firefox Lockwise). I installed Bitwarden addon and 2 Keylogger Addons (not malicious, their job is literally to log keystrokes inside the browser). Those were: Takker could log what I type in the urlbar and what I type inside a website. Nifty Keylogger logged only what I typed inside the website. |
Yes the original suggestion was made in the context of Bitwarden being compromised, but this suggestion is also beneficial for other threats such as keyloggers as you tested, so I think the variety of issues that this tip solves is a good argument to add it, that's why I made this PR :-) About sign-in, are these keyloggers able to capture autofilled passwords by Bitwarden plug-in? Because that's why I thought the plug-in was safer, and intended to add another tip about. /EDIT: Oh wow, Tackker on Chrome can indeed capture autofilled passwords. It can also capture copy/pasted credentials. |
Signed-off-by: Stephen L. <[email protected]>
I have updated the tip per our discussion above. Please re-evaluate it. |
Yup, I belive this fixes the issue with the potential malicious javascripts. not relevant to Bitwarden but: |
Description
Resolves: Suggestion by @ThracianKnight1907 at #1915 (comment)
Check List
I understand that by not opening an issue about a software/service/similar addition/removal, this pull request will be closed without merging.
I have read and understand the contributing guidelines.
The project is Free Libre and/or Open Source Software