Skip to content
This repository has been archived by the owner on Dec 27, 2023. It is now read-only.

Improved the code to be excluded in codeclimate. #333

Closed

Conversation

opg7371
Copy link

@opg7371 opg7371 commented Feb 18, 2016

This is regarding the issue #328
I have excluded all the files which are-
-All scripts in a vendor directory
-All ZeroBin scripts
-All test-related scripts which are
-test files in test directory
-test files in other directories

please review it too....:)

ratings:
paths:
-app/**
-lib/**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you copied these directories from an example. We have no lib directory, app directory, or .go files. We also don't want to rate the Ruby files in this repo.

@smcgregor
Copy link
Member

Pull requests should be made against the develop branch.

#331 was opened earlier and has fewer issues. I am going to merge #331, but there is still room for improvement in it. Specifically, your list of excluded files is more complete.

@smcgregor smcgregor closed this Feb 18, 2016
@smcgregor smcgregor mentioned this pull request Feb 18, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants