Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove the component of newsletter subscription #1380

Merged
merged 3 commits into from
Jan 17, 2025
Merged

feat: remove the component of newsletter subscription #1380

merged 3 commits into from
Jan 17, 2025

Conversation

csouchet
Copy link
Member

@csouchet csouchet commented Jan 14, 2025 •
edited
Loading

BeforeNow

@csouchet csouchet added the enhancement New feature or request label Jan 14, 2025
@github-actions github-actions bot added the build label Jan 14, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 14, 2025 •
edited
Loading

🎊 PR Preview 73b8094 has been successfully built and deployed to https://process-analytics-process-analytics-dev-site_preview-pr-1380.surge.sh

🕐 Build time: 51.49s

🤖 By surge-preview

@csouchet csouchet marked this pull request as ready for review January 14, 2025 13:43
@csouchet csouchet requested a review from tbouffard January 14, 2025 13:43
@csouchet csouchet force-pushed the feat/remove_newsletter branch from 8e290f1 to 25d7d9e Compare January 15, 2025 17:14
tbouffard
tbouffard approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
✔️ Tested with the surge preview environment

@csouchet csouchet enabled auto-merge (squash) January 17, 2025 09:31
@csouchet csouchet merged commit fa8145b into main Jan 17, 2025
5 checks passed
@csouchet csouchet deleted the feat/remove_newsletter branch January 17, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbouffard tbouffard tbouffard approved these changes

Assignees
No one assigned
Labels
build enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csouchet @tbouffard