Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: use repo variable to use same ubuntu runner in all workflows #1383

Closed
wants to merge 1 commit into from
Closed

ci: use repo variable to use same ubuntu runner in all workflows #1383

wants to merge 1 commit into from

Conversation

csouchet
Copy link
Member

@csouchet csouchet commented Jan 17, 2025 •
edited by tbouffard
Loading

Covers #821

@csouchet csouchet added the chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) label Jan 17, 2025
@github-actions github-actions bot added the github_actions Pull requests that update GitHub Actions code label Jan 17, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 17, 2025 •
edited
Loading

♻️ PR Preview 071c210 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@csouchet csouchet marked this pull request as ready for review January 17, 2025 15:53
@csouchet csouchet requested review from tbouffard January 17, 2025 15:53
tbouffard
tbouffard reviewed Jan 17, 2025
View reviewed changes
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Using variables in public repository has a major drawback.
PR from fork repositories hasn't access to variables, this is why we stop this initiative

See https://github.com/orgs/process-analytics/projects/7?pane=issue&itemId=18679583

@csouchet
Copy link
Member Author

Replaced by #1384

@csouchet csouchet closed this Jan 17, 2025
@tbouffard tbouffard deleted the ci/use_ubuntu_runner_version_from_organisation branch January 17, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbouffard tbouffard Awaiting requested review from tbouffard

Assignees
No one assigned
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csouchet @tbouffard