This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
fix(config): use ioutil.WriteFile instead of renameio #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported apparently renameio does not work on windows and there's no obvious way to even make an atomic file overwrite on windows at all, thus renameio is looking at dropping Windows support. This change simply switches to ioutil.WriteFile which is not atomic but the code should still be nicer than the previous one we replaced. While at it also cut down on the readability part of the files permissions as the config file could contain sensitive information (like the token). Fixes profclems#210
|
Best reviewed: commit by commit
Optimal code review plan
|
profclems
reviewed
Sep 7, 2020
There was a problem hiding this comment.
I don't know if this is a right decision to make the atm.
I'm thinking the need of importing/linking runtime (and renameio on windows) could be avoided by creating a WriteFile helper method in a file which has a !+build windows and another writefile_windows.go which implements WrifeFile using ioutil.WriteFile.
This looks like a fairly optimal solution for me.
|
Ok, published #212 as a replacement for this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported apparently renameio does not work on windows and there's
no obvious way to even make an atomic file overwrite on windows at all,
thus renameio is looking at dropping Windows support.
This change simply switches to ioutil.WriteFile which is not atomic
but the code should still be nicer than the previous one we replaced.
While at it also cut down on the readability part of the files
permissions as the config file could contain sensitive information
(like the token).
Fixes #210