This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
fix(config): Use ioutil.WriteFile on Windows #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported renameio doesn't work on Windows and apparently there's no way to do atomic file replace on Windows. We thus create a helper function in a separate file that uses renameio but say it should not be built on windows, then hook in a windows- specific implementation of that function which uses ioutil.WriteFile which is not safe but gets the job done. While at it also tighten up the permissions on the config file as it might contain sensitive information (like the token). Fixes profclems#210
|
Best reviewed: commit by commit
Optimal code review plan
|
|
Note that this has not actually been tested on windows (except GOOS=windows cross-build). |
|
I also have no idea how to make renameio in go.sum not apply on windows. I guess that means people building on Windows will still have to download renameio even if it will not be used in the build? |
profclems
approved these changes
Sep 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported renameio doesn't work on Windows and apparently there's
no way to do atomic file replace on Windows.
We thus create a helper function in a separate file that uses renameio
but say it should not be built on windows, then hook in a windows-
specific implementation of that function which uses ioutil.WriteFile
which is not safe but gets the job done.
While at it also tighten up the permissions on the config file as
it might contain sensitive information (like the token).
Fixes #210