Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add user_id to get_comments and bugfix #56

Merged
merged 4 commits into from
Nov 24, 2024
Merged

add user_id to get_comments and bugfix #56

merged 4 commits into from
Nov 24, 2024

Conversation

zipperman1
Copy link
Contributor

@zipperman1 zipperman1 commented Nov 18, 2024

Изменения

добавил возможность фильтровать комментарии по user_id

Детали реализации

Добавил параметр функции get_comments user_id

Check-List

  • Вы проверили свой код перед отправкой запроса?
  • Вы написали тесты к реализованным функциям?
  • Вы не забыли применить форматирование black и isort для Back-End или Prettier для Front-End?

@zipperman1 zipperman1 self-assigned this Nov 18, 2024
@zipperman1 zipperman1 linked an issue Nov 18, 2024 that may be closed by this pull request
@zipperman1 zipperman1 requested a review from Zimovchik November 18, 2024 16:51
Copy link

💩 Code linting failed, use black and isort to fix it.

Copy link

github-actions bot commented Nov 18, 2024

Code Coverage

Coverage Report
FileStmtsMissCoverMissing
rating_api
   __main__.py440%1–7
   exceptions.py26388%35–36, 44
rating_api/models
   base.py55591%24–27, 76
   db.py63592%57–61
rating_api/routes
   comment.py681282%28, 34–37, 90, 100–105, 112, 134, 149
   exc_handlers.py20290%26, 33
   lecturer.py901781%106, 116–140, 143, 158, 166, 184, 190
rating_api/schemas
   base.py12467%6–9
TOTAL4415288% 

Summary

Tests Skipped Failures Errors Time
35 0 💤 0 ❌ 0 🔥 2.832s ⏱️

Copy link
Member

@Zimovchik Zimovchik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

вроде все норм, тесты ток поправь

tests/conftest.py Outdated Show resolved Hide resolved
@zipperman1 zipperman1 requested a review from Zimovchik November 18, 2024 18:43
@Zimovchik Zimovchik requested a review from Temmmmmo November 19, 2024 17:31
Copy link
Member

@Temmmmmo Temmmmmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

надо сделать это через проперти для таблицы, Тимур такое делал
у него в ПРе для сортировки есть. посмотри
ну или просто доку алхимии прочитай)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Добавить в ручку GET/comments параметр user_id
3 participants