Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing comment post route + fixing validation models #74

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Zimovchik
Copy link
Member

@Zimovchik Zimovchik commented Dec 16, 2024

Изменения

  • Убрал функционал импорта из post comment
  • переделал схемы валидации(убрал наследование)

Check-List

  • Вы проверили свой код перед отправкой запроса?
  • Вы написали тесты к реализованным функциям?
  • Вы не забыли применить форматирование black и isort для Back-End или Prettier для Front-End?

Захаров Иван Михайлович added 2 commits December 16, 2024 11:06
Copy link

github-actions bot commented Dec 16, 2024

Code Coverage

Coverage Report
FileStmtsMissCoverMissing
rating_api
   __main__.py440%1–7
   exceptions.py34779%35–37, 48–50, 58
rating_api/models
   base.py55591%24–27, 76
   db.py73297%61, 74
rating_api/routes
   comment.py791877%30, 35–38, 75–84, 127, 137–142, 149, 172, 188
   exc_handlers.py23387%33, 40, 47
   lecturer.py841483%132–153, 169, 177, 195, 201
rating_api/schemas
   base.py12467%6–9
   models.py87397%55–57
TOTAL4916088% 

Summary

Tests Skipped Failures Errors Time
40 0 💤 0 ❌ 0 🔥 2.737s ⏱️

@Zimovchik Zimovchik self-assigned this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant