Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Req. scope for comment creation #85

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

DaymasS
Copy link
Contributor

@DaymasS DaymasS commented Dec 27, 2024

Изменения

Добавлен скоуп для создания комментария

Детали реализации

Check-List

  • Вы проверили свой код перед отправкой запроса?
  • Вы написали тесты к реализованным функциям?
  • Вы не забыли применить форматирование black и isort для Back-End или Prettier для Front-End?

@DaymasS DaymasS requested a review from Temmmmmo December 27, 2024 20:35
@DaymasS DaymasS self-assigned this Dec 27, 2024
Copy link

💩 Code linting failed, use black and isort to fix it.

Copy link

github-actions bot commented Dec 27, 2024

Code Coverage

Coverage Report
FileStmtsMissCoverMissing
rating_api
   __main__.py440%1–7
   exceptions.py34779%35–37, 48–50, 58
rating_api/models
   base.py55591%24–27, 76
   db.py73297%61, 74
rating_api/routes
   comment.py881978%35, 39, 57, 75, 110–119, 162, 172–177, 184, 208, 224
   exc_handlers.py23387%33, 40, 47
   lecturer.py841483%132–155, 171, 179, 197, 203
rating_api/schemas
   base.py12467%6–9
TOTAL4885888% 

Summary

Tests Skipped Failures Errors Time
40 0 💤 0 ❌ 0 🔥 2.821s ⏱️

Comment on lines +138 to +140
lecturer_to_result.comments = sorted(
approved_comments, key=lambda comment: comment.create_ts, reverse=True
)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Исключительно линтинг, логика не была затронута

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant