Wavlen in settings #138
Open
Wavlen in settings #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
profezzorn
reviewed
Jan 26, 2025
style_editor.html
Outdated
| @@ -10503,21 +10532,26 @@ <h4 class="settings-section-label" title="These settings are useful for people m | |||
| } | |||
|
|
|||
| class SavedState { | |||
| constructor(name, def, update_function) { | |||
| constructor(name, def, update_function, type = "checkbox") { | |||
There was a problem hiding this comment.
A more object-oreiented way to do this would be to have two subclasses: SavedStateBool and SavedStateNumber (or something like that). Both would inherit from SavedState and override just the parts required. (Which I guess would be the set() function.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow WavLen to be adjusted in Settings Menu.
Change handleClick() to better named handleSettings(), esp since now there's a value, not just a click.