Change knox token certificate argument from path to object (#4)

proget-hq · Jul 29, 2019 · 6c3165b · 6c3165b
1 parent a5723b4
commit 6c3165b
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 10 deletions.
diff --git a/README.md b/README.md
@@ -15,17 +15,19 @@ More info at [Knox Cloud API Integration Guide](https://docs.samsungknox.com/clo
 ### Sign your Client Identifier
 
 ```php
+use Proget\Samsung\KnoxToken\Certificate;
 use Proget\Samsung\KnoxToken\KnoxToken;
 
-$clientIdentifierJwt = KnoxToken::signClientIdentifier('your-client-identifier', 'keys.json');
+$clientIdentifierJwt = KnoxToken::signClientIdentifier('your-client-identifier', Certificate::fromPath('keys.json'));
 ```
 
 ### Sign your Access Token
 
 ```php
+use Proget\Samsung\KnoxToken\Certificate;
 use Proget\Samsung\KnoxToken\KnoxToken;
 
-$accessTokenJwt = KnoxToken::signAccessToken('access-token', 'keys.json');
+$accessTokenJwt = KnoxToken::signAccessToken('access-token', Certificate::fromPath('keys.json'));
 ```
 
 ### Load certificate

diff --git a/src/KnoxToken.php b/src/KnoxToken.php
@@ -11,10 +11,8 @@ class KnoxToken
 {
     private const AUDIENCE = 'KnoxWSM';
 
-    public static function signClientIdentifier(string $clientIdentifier, string $certificatePath): string
+    public static function signClientIdentifier(string $clientIdentifier, Certificate $certificate): string
     {
-        $certificate = Certificate::fromPath($certificatePath);
-
         return JWT::encode([
             'clientIdentifier' => $clientIdentifier,
             'publicKey' => $certificate->publicKey(),
@@ -23,10 +21,8 @@ public static function signClientIdentifier(string $clientIdentifier, string $ce
         ], $certificate->privateKeyPem(), 'RS512');
     }
 
-    public static function signAccessToken(string $accessToken, string $certificatePath): string
+    public static function signAccessToken(string $accessToken, Certificate $certificate): string
     {
-        $certificate = Certificate::fromPath($certificatePath);
-
         return JWT::encode([
             'accessToken' => $accessToken,
             'publicKey' => $certificate->publicKey(),

diff --git a/tests/KnoxTokenTest.php b/tests/KnoxTokenTest.php
@@ -5,6 +5,7 @@
 namespace Proget\Tests\Samsung\KnoxToken;
 
 use PHPUnit\Framework\TestCase;
+use Proget\Samsung\KnoxToken\Certificate;
 use Proget\Samsung\KnoxToken\KnoxToken;
 
 class KnoxTokenTest extends TestCase
@@ -13,15 +14,15 @@ public function testSignClientIdentifier(): void
     {
         self::assertEquals(713, \strlen(KnoxToken::signClientIdentifier(
             'a33a7593-dbaf-457f-87be-19243a421aec',
-            __DIR__.'/keys.json'
+            Certificate::fromPath(__DIR__.'/keys.json')
         )));
     }
 
     public function testSignAccessToken(): void
     {
         self::assertEquals(707, \strlen(KnoxToken::signAccessToken(
             'd13d112e-8e77-4243-b795-ed4e1cf15cf9',
-            __DIR__.'/keys.json'
+            Certificate::fromPath(__DIR__.'/keys.json')
         )));
     }
 }