Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to reduce the override-time on override-page #283

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Thomas131
Copy link

This is my first PoC which enables a user to limit the override-time on the override-page.

Is that OK? Should I make any further changes? (Or feel free to make the changes yourself)

closes #272

@Thomas131
Copy link
Author

Hi @proginosko
I would love your feedback :)

@proginosko
Copy link
Owner

Sorry for the delay in replying. LB is a hobby for me and unfortunately I have very little time to work on it right now. I will try to take a look at this over the Christmas break.

@Thomas131
Copy link
Author

Hi @proginosko, any updates on this PR?

@proginosko
Copy link
Owner

Sorry for the delay. I just took a look at it. I guess I like the idea, but I'm not sold on the implementation. There were some UI issues at my end (scroll bar appears in dialogue box, slider changes size, shows negative numbers).

I wonder how much demand there is to adjust the override duration like this. I don't recall any users requesting it. But if it were implemented, I would prefer it to appear on the override page itself, rather than in a dialogue box. Also, some users have requested the option to specify a per-set override duration, so any option to adjust the duration would need to be coordinated with that. So I'm not ready to pull this into the project in its current form. Sorry to disappoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: On Override-Page further limit overriding-Time
2 participants