[FIX] Update Network Check Method In Installation Script #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonio-amjr
added
Bug
|
Review changes with |
rquidute
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #491
Updating the docker's network service connectivity check on installation script exchanging the ping usage for a direct TCP package test.
As per the issue associated above, the ping tool uses the ICMP protocol that may be blocked by the local firewall of some users. The benefit of using TCP package exchange is that no tool is required to be installed in the Raspberry Pi's OS since it's a resource already present in the system.
For the logic of the check, the connectivity is tested five times against the docker's download service URL, waiting a few seconds before trying again and cancelling in case of failure.