Skip to content

Commit

Permalink
Update specification revision and test (#37367)
Browse files Browse the repository at this point in the history
* Spec revisions: Update to 1.4.1

* TC-BINFO-2.1: Update for dot requirements

* minor rewording

* Restyled by prettier-yaml

* Update expected value in test

---------

Co-authored-by: Restyled.io <[email protected]>
  • Loading branch information
cecille and restyled-commits authored Feb 5, 2025
1 parent e797f33 commit f64bec5
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions src/app/SpecificationDefinedRevisions.h
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ namespace Revision {
* See section 8.1.1. "Revision History" in the "Interaction Model
* Specification" chapter of the core Matter specification.
*/
inline constexpr InteractionModelRevision kInteractionModelRevision = 11;
inline constexpr InteractionModelRevision kInteractionModelRevision = 12;
inline constexpr uint8_t kInteractionModelRevisionTag = 0xFF;

/**
Expand All @@ -50,7 +50,7 @@ inline constexpr uint16_t kDataModelRevision = 18;
* See section 11.1.5.22. "SpecificationVersion Attribute" in "Service and
* Device Management" chapter of the core Matter specification.
*/
inline constexpr uint32_t kSpecificationVersion = 0x01040000;
inline constexpr uint32_t kSpecificationVersion = 0x01040100;

} // namespace Revision
} // namespace chip
2 changes: 1 addition & 1 deletion src/app/tests/suites/TestBasicInformation.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ tests:
attribute: "SpecificationVersion"
response:
# For now all-clusters-app has a version 1.4.
value: 0x01040000
value: 0x01040100

- label: "Read the Max Paths Per Invoke value"
command: "readAttribute"
Expand Down
8 changes: 4 additions & 4 deletions src/app/tests/suites/certification/Test_TC_BINFO_2_1.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -715,16 +715,16 @@ tests:
response:
value: ProductAppearancevalue

# This list should be expanded as we expand the TH to support more specification revisions
- label:
"Step 62: SpecificationVersion value should in the inclusive range of
(0x01040000 to 0x0104FF00) and the lower 8 bits are set to zero."
"Step 62: SpecificationVersion value should be set to a valid Major,
Minor, and Dot version with the lower 8 bits set to zero."
command: "readAttribute"
attribute: "SpecificationVersion"
response:
saveAs: SpecificationVersionValue
constraints:
minValue: 0x01040000
maxValue: 0x0104FF00
anyOf: [0x01040000, 0x01040100]
hasMasksClear: [0x1, 0x2, 0x4, 0x8, 0x10, 0x20, 0x40, 0x80]

- label:
Expand Down

0 comments on commit f64bec5

Please sign in to comment.