[Test]Creating TC_MOD_1_2 python module: #37349
Open
+105
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Creating TC_MOD_1_2 python module based on task by Cecille @ project-chip/matter-test-scripts#483
|
Review changes with |
- Resolving linting errors
|
PR #37349: Size comparison from 95d5de5 to d652160 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
- Updated to include ref links for info on StandardNamespace and OnMode values
cecille
reviewed
Feb 4, 2025
src/python_testing/TC_MOD_1_2.py
Outdated
| attributes = MOD_cluster.Attributes | ||
|
|
||
| if await self.attribute_guard(endpoint=self.endpoint, attribute=attributes.SupportedModes): | ||
| mode_options = await self.read_single_attribute(dev_ctrl=self.th1, node_id=self.dut_node_id, endpoint=self.endpoint, attribute=attributes.SupportedModes) |
There was a problem hiding this comment.
The checks in the test plan are more in depth here. I don't think we have a machine-readable version of the standard namespaces right now, so leave that piece for now, but there are some checks that should be in here. See test plan. In particular, unique modes.
src/python_testing/TC_MOD_1_2.py
Outdated
| if await self.attribute_guard(endpoint=self.endpoint, attribute=attributes.StandardNamespace): | ||
| # Currently appears to return a 0 by default, need to check on this to make sure it is acceptable | ||
| #Ref Link: https://github.com/CHIP-Specifications/connectedhomeip-spec/blob/06c4d55962954546ecf093c221fe1dab57645028/src/app_clusters/ModeSelect.adoc#62-standardnamespace-attribute | ||
| Standard_Namespace = await self.read_single_attribute(dev_ctrl=self.th1, node_id=self.dut_node_id, endpoint=self.endpoint, attribute=attributes.StandardNamespace) |
There was a problem hiding this comment.
Suggested change
| Standard_Namespace = await self.read_single_attribute(dev_ctrl=self.th1, node_id=self.dut_node_id, endpoint=self.endpoint, attribute=attributes.StandardNamespace) | |
| standard_namespace = await self.read_single_attribute(dev_ctrl=self.th1, node_id=self.dut_node_id, endpoint=self.endpoint, attribute=attributes.StandardNamespace) |
There was a problem hiding this comment.
The verification here should be that this is actually a real namespace, which I don't think 0 is. But also, we don't have a machine-readable source yet, so let's handle that in a follow up.
There was a problem hiding this comment.
just talked to hasty, and we have a scraper for these. I won't have a chance to do anything about it for a few days, but let me see about grabbing the data. Maybe you can be the person who writes the parser - that's more fun than test cases for the most part.
There was a problem hiding this comment.
That sounds great to me, I would enjoy if I was able to be the one who got to write the parser here!
- Updating test code based on recent suggestions from Cecille Co-authored-by: C Freeman <[email protected]>
- Updating test module to remove checks for mandatory attributes
- Readding missing test step identifiers
- Re-input missing test step numbers
- Added check to make sure that all values for modes in SupportedModes are unique values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing