Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick: Fix key error when using TLV dictionary in DeviceConformance test. (#… #37465

Merged
merged 1 commit into from
Feb 8, 2025
Merged

Cherry-pick: Fix key error when using TLV dictionary in DeviceConformance test. (#… #37465

merged 1 commit into from
Feb 8, 2025

Conversation

cecille
Copy link
Contributor

@cecille cecille commented Feb 7, 2025

…37268)

  • Change reference from TLV endpoint

  • Change test endpoint function

  • Fix issue with attr list

  • Add handling for TLV attributes

Testing

runs in CI

@tersal @cecille
Fix key error when using TLV dictionary in DeviceConformance test. (p…
32a413c 
…roject-chip#37268)

* Change reference from TLV endpoint

* Change test endpoint function

* Fix issue with attr list

* Add handling for TLV attributes
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Feb 7, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  src/python_testing/TC_DeviceConformance.py  74% smaller
  src/python_testing/TestConformanceTest.py  26% smaller

@github-actions github-actions bot added tests matter-1.4-te2-script-change Script changes before end of Matter 1.4 TE2 labels Feb 7, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2025 •
edited
Loading

PR #37465: Size comparison from a0b6593 to 32a413c

Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section a0b6593 32a413c change % change
bl602 lighting-app bl602 FLASH 1280588 1280588 0 0.0
RAM 96000 96000 0 0.0
bl602+mfd FLASH 1308892 1308892 0 0.0
RAM 95656 95656 0 0.0
bl602+rpc FLASH 1335256 1335256 0 0.0
RAM 103976 103976 0 0.0
bl702 lighting-app bl702 FLASH 944990 944990 0 0.0
RAM 15105 15105 0 0.0
bl702+mfd FLASH 957700 957700 0 0.0
RAM 14769 14769 0 0.0
bl702+rpc FLASH 1051148 1051148 0 0.0
RAM 23661 23661 0 0.0
bl706-eth FLASH 658122 658122 0 0.0
RAM 24745 24745 0 0.0
bl706-wifi FLASH 824918 824918 0 0.0
RAM 13965 13965 0 0.0
bl702l lighting-app bl702l FLASH 961926 961926 0 0.0
RAM 16804 16804 0 0.0
bl702l+mfd FLASH 974688 974688 0 0.0
RAM 16468 16468 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 829372 829372 0 0.0
RAM 123452 123452 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 814696 814696 0 0.0
RAM 125332 125332 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 761276 761276 0 0.0
RAM 113824 113824 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 745512 745512 0 0.0
RAM 114016 114016 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 616950 616950 0 0.0
RAM 205908 205908 0 0.0
lock CC3235SF_LAUNCHXL FLASH 657054 657054 0 0.0
RAM 206060 206060 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 678341 678341 0 0.0
RAM 78668 78668 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 698193 698193 0 0.0
RAM 81300 81300 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 698193 698193 0 0.0
RAM 81300 81300 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 655129 655129 0 0.0
RAM 73736 73736 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 614685 614685 0 0.0
RAM 71628 71628 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 634313 634313 0 0.0
RAM 74180 74180 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 634313 634313 0 0.0
RAM 74180 74180 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 633997 633997 0 0.0
RAM 74676 74676 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 653713 653713 0 0.0
RAM 77228 77228 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 653713 653713 0 0.0
RAM 77228 77228 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 609293 609293 0 0.0
RAM 68764 68764 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 629153 629153 0 0.0
RAM 71396 71396 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 629153 629153 0 0.0
RAM 71396 71396 0 0.0
efr32 lighting-app BRD4187C FLASH 934132 934124 -8 -0.0
RAM 136244 136244 0 0.0
lock-app BRD2605a FLASH 741288 741280 -8 -0.0
RAM 232120 232120 0 0.0
BRD4338a FLASH 741720 741712 -8 -0.0
RAM 232004 232004 0 0.0
window-app BRD4187C FLASH 1017568 1017528 -40 -0.0
RAM 128176 128176 0 0.0
esp32 all-clusters-app c3devkit DRAM 94240 94240 0 0.0
FLASH 1538502 1538502 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115192 115192 0 0.0
FLASH 1548938 1548938 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4688 4688 0 0.0
FLASH 2779879 2779879 0 0.0
RAM 129488 129488 0 0.0
all-clusters-app debug unknown 5528 5528 0 0.0
FLASH 6083822 6083822 0 0.0
RAM 510528 510528 0 0.0
all-clusters-minimal-app debug unknown 5424 5424 0 0.0
FLASH 5417104 5417104 0 0.0
RAM 241200 241200 0 0.0
bridge-app debug unknown 5408 5408 0 0.0
FLASH 4750526 4750526 0 0.0
RAM 218384 218384 0 0.0
chip-tool debug unknown 5960 5960 0 0.0
FLASH 12655296 12655296 0 0.0
RAM 560626 560626 0 0.0
chip-tool-ipv6only arm64 unknown 20672 20672 0 0.0
FLASH 1129344 1129344 0 0.0
RAM 610944 610944 0 0.0
fabric-admin debug unknown 5792 5792 0 0.0
FLASH 11007949 11007949 0 0.0
RAM 560058 560058 0 0.0
fabric-bridge-app debug unknown 4632 4632 0 0.0
FLASH 4573492 4573492 0 0.0
RAM 205048 205048 0 0.0
lighting-app debug+rpc+ui unknown 6056 6056 0 0.0
FLASH 5690305 5690305 0 0.0
RAM 228456 228456 0 0.0
lock-app debug unknown 5344 5344 0 0.0
FLASH 4800122 4800122 0 0.0
RAM 204472 204472 0 0.0
ota-provider-app debug unknown 4720 4720 0 0.0
FLASH 4429510 4429510 0 0.0
RAM 198192 198192 0 0.0
ota-requestor-app debug unknown 4656 4656 0 0.0
FLASH 4568326 4568326 0 0.0
RAM 202760 202760 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 3109917 3109917 0 0.0
RAM 159280 159280 0 0.0
thermostat-no-ble arm64 unknown 9448 9448 0 0.0
FLASH 4317968 4317968 0 0.0
RAM 242936 242936 0 0.0
tv-app debug unknown 5624 5624 0 0.0
FLASH 6027957 6027957 0 0.0
RAM 584064 584064 0 0.0
tv-casting-app debug unknown 5208 5208 0 0.0
FLASH 10849405 10849405 0 0.0
RAM 648912 648912 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 914284 914284 0 0.0
RAM 142359 142359 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 885076 885076 0 0.0
RAM 140498 140498 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 847688 847688 0 0.0
RAM 141253 141253 0 0.0
nxp contact k32w0+release FLASH 582024 582024 0 0.0
RAM 70944 70944 0 0.0
k32w1+release FLASH 596752 596752 0 0.0
RAM 63168 63168 0 0.0
mcxw71+release FLASH 596512 596512 0 0.0
RAM 63168 63168 0 0.0
light k32w0+release FLASH 618628 618628 0 0.0
RAM 70416 70416 0 0.0
k32w1+release FLASH 682728 682728 0 0.0
RAM 48808 48808 0 0.0
mcxw71+release FLASH 682744 682744 0 0.0
RAM 48808 48808 0 0.0
lock k32w1+release FLASH 705088 705088 0 0.0
RAM 67308 67308 0 0.0
mcxw71+release FLASH 705112 705112 0 0.0
RAM 67308 67308 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646140 1646140 0 0.0
RAM 211400 211400 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1552196 1552196 0 0.0
RAM 208200 208200 0 0.0
light cy8ckit_062s2_43012 FLASH 1467668 1467668 0 0.0
RAM 201200 201200 0 0.0
lock cy8ckit_062s2_43012 FLASH 1464740 1464740 0 0.0
RAM 225560 225560 0 0.0
qpg lighting-app qpg6105+debug FLASH 660392 660392 0 0.0
RAM 105396 105396 0 0.0
lock-app qpg6105+debug FLASH 618404 618404 0 0.0
RAM 99864 99864 0 0.0
stm32 light STM32WB5MM-DK FLASH 481680 481680 0 0.0
RAM 144844 144844 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 620790 620790 0 0.0
RAM 50648 50648 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 687992 687992 0 0.0
RAM 148488 148488 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 780984 780984 0 0.0
RAM 110440 110440 0 0.0
bridge-app tlsr9258a FLASH 680894 680894 0 0.0
RAM 91304 91304 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 620554 620554 0 0.0
RAM 50600 50600 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 708494 708494 0 0.0
RAM 73940 73940 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 625498 625498 0 0.0
RAM 144468 144468 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 811258 811258 0 0.0
RAM 99100 99100 0 0.0
lock-app-dfu tlsr9528a FLASH 656460 656460 0 0.0
RAM 66660 66660 0 0.0
ota-requestor-app tlsr9258a FLASH 696870 696870 0 0.0
RAM 90896 90896 0 0.0
pump-app-usb tlsr9518adk80d FLASH 634186 634186 0 0.0
RAM 55476 55476 0 0.0
pump-controller-app tlsr9518adk80d FLASH 611376 611376 0 0.0
RAM 52720 52720 0 0.0
shell tlsr9518adk80d FLASH 467862 467862 0 0.0
RAM 68168 68168 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 627714 627714 0 0.0
RAM 52312 52312 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 653512 653512 0 0.0
RAM 56268 56268 0 0.0
thermostat tlsr9518adk80d FLASH 638108 638108 0 0.0
RAM 53112 53112 0 0.0
window-covering tlsr9118bdk40d FLASH 524254 524254 0 0.0
RAM 97444 97444 0 0.0
tizen all-clusters-app arm unknown 4904 4904 0 0.0
FLASH 1725928 1725928 0 0.0
RAM 89076 89076 0 0.0
chip-tool-ubsan arm unknown 10424 10424 0 0.0
FLASH 17524618 17524618 0 0.0
RAM 7627904 7627904 0 0.0

@andy31415 andy31415 merged commit de5c5e6 into project-chip:v1.4-branch Feb 8, 2025
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

Assignees
No one assigned
Labels
matter-1.4-te2-script-change Script changes before end of Matter 1.4 TE2 tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cecille @andy31415 @tersal