Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mdnsresponder package and update openthread-br to use it by default #25

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

ksperling-apple
Copy link
Contributor

  • Add mdnsresponder package

  • Use mdnsresponder for openthread-br by default

    The new openthread-br-avahi variant of the package continues to use Avahi.

    Also tweak a few build options and default the UART baud rate to 460800; USB
    RCPs generally support this baud rate and it avoids the UART interface being
    the bottleneck for the border router.

Copy link

semanticdiff-com bot commented Oct 15, 2024

Review changes with  SemanticDiff

@ksperling-apple ksperling-apple force-pushed the mdns-otbr branch 2 times, most recently from b1d1f0d to fa9507b Compare October 15, 2024 22:29
@agners
Copy link

agners commented Oct 16, 2024

Nice, we use mDNSResponder for the Home Assistant OTBR add-on as well. I've upstreamed a mDNSResponder bump with some patches a while ago, I guess you have seen those patches (see https://github.com/openthread/ot-br-posix/tree/main/third_party/mDNSResponder)? Maybe some of these patches are also worth upstreaming? 🤔

@ksperling-apple
Copy link
Contributor Author

Nice, we use mDNSResponder for the Home Assistant OTBR add-on as well. I've upstreamed a mDNSResponder bump with some patches a while ago, I guess you have seen those patches (see https://github.com/openthread/ot-br-posix/tree/main/third_party/mDNSResponder)? Maybe some of these patches are also worth upstreaming? 🤔

Ah, I didn't realize there was a version of this in the OTBR repo, I'll have a look at those.

The new openthread-br-avahi variant of the package continues to use Avahi.

Also tweak a few build options and default the UART baud rate to 460800; USB
RCPs generally support this baud rate and it avoids the UART interface being
the bottleneck for the border router.
@ksperling-apple ksperling-apple merged commit 79a078c into project-chip:main Nov 20, 2024
4 checks passed
@ksperling-apple ksperling-apple deleted the mdns-otbr branch November 20, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants