Remove $Changed from logical flow of emitter #1394
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files |
pullapprove
bot
requested review from
Apollon77,
turon,
vves and
woody-apple
lauckhart
force-pushed
the
changed-reactor-tx-fix
branch
from
4f25b37 to
9375f6c
Compare
|
see review comments in Discord - also reason for the failed testcase |
lauckhart
force-pushed
the
changed-reactor-tx-fix
branch
from
f92f587 to
74ff494
Compare
Previously we were providing the ActionContext of the emitter to $Changed handlers. The transaction was destroyed in this case so was not really useful. Now we instead just provide metadata about the subject that triggered the change. Also, the emitter was awaiting $Changed handlers if they were async. There are advantages and disadvantages to doing this: * Advantage is that the logical flow is more deterministic and we track the promise as a normal part of node activity * The disadvantage is that the emitter blocks until an independent process completes This commit makes it so $Changed handlers operate independently of the emitter. Tests pass but effects will be subtle so will need to keep an eye on this.
Untested as yet
...when computing ACL changes
...to make cert tests happy
lauckhart
force-pushed
the
changed-reactor-tx-fix
branch
from
ddf6584 to
d822be8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were providing the ActionContext of the emitter to $Changed handlers. The transaction was destroyed in this case so was not really useful. Now we instead just provide metadata about the subject that triggered the change.
Also, the emitter was awaiting $Changed handlers if they were async. There are advantages and disadvantages to doing this:
This commit makes it so $Changed handlers operate independently of the emitter. Tests pass but effects will be subtle so will need to keep an eye on this.