Trigger event listeners before attribute listeners for Subscriptions #1658
+38
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In fact happened events usually lead to a new "final attribute status" which is also reported. To mimic this a bit better we should trigger event listeners before attribute listeners. This could halp a lot with e.g. Switch events where events report presses, but the switch position is reported as "0".
|
Review changes with Changed Files
|
Apollon77
commented
Jan 24, 2025
| @@ -9,6 +9,10 @@ The main work (all changes without a GitHub username in brackets in the below li | |||
| ## __WORK IN PROGRESS__ | |||
| --> | |||
|
|
|||
| ## __WORK IN PROGRESS__ | |||
| - @matter/protocol | |||
There was a problem hiding this comment.
Open a dummy comment ... I send this to the current Controller implementors to request feedback ...
Do you have any opinion if this is breaking or makes sense? I found it problematic getting the switch button events but then the "currentPosition" was reported as "0" before these events. if you consider breaking I would make it configurable ... else just is different behavior. WDYT?
lauckhart
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In fact happened events usually lead to a new "final attribute status" which is also reported. To mimic this a bit better we should trigger event listeners before attribute listeners. This could halp a lot with e.g. Switch events where events report presses, but the switch position is reported as "0".