bug where attribute reporting dissapears #1514
Conversation
paulr34
changed the title
paulr34
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1514 +/- ##
==========================================
- Coverage 66.76% 66.56% -0.20%
==========================================
Files 193 194 +1
Lines 20999 21707 +708
Branches 4614 4798 +184
==========================================
+ Hits 14020 14450 +430
- Misses 6979 7257 +278 ☔ View full report in Codecov by Sentry. |
| listType === 'selectedAttributes' && | ||
| attributeData.isReportable | ||
| ) { | ||
| editContext.listType = 'selectedReporting' |
There was a problem hiding this comment.
What does editContext.listType = 'selectedReporting' do?
There was a problem hiding this comment.
It identifies the list type
There was a problem hiding this comment.
if ( addedValue && listType === 'selectedAttributes' && attributeData.isReportable ) { editContext.listType = 'selectedReporting' } this.$store.dispatch('zap/updateSelectedAttribute', editContext)
Will be safer to do this. Getting rid of that line can cause issues if unsure of its removal.
There was a problem hiding this comment.
it breaks because both dispatch collide with each other
I think you're right.
| listType === 'selectedAttributes' && | ||
| attributeData.isReportable | ||
| ) { | ||
| editContext.listType = 'selectedReporting' |
There was a problem hiding this comment.
if ( addedValue && listType === 'selectedAttributes' && attributeData.isReportable ) { editContext.listType = 'selectedReporting' } this.$store.dispatch('zap/updateSelectedAttribute', editContext)
Will be safer to do this. Getting rid of that line can cause issues if unsure of its removal.
paulr34
changed the title
No description provided.