return GUI data for selected endpoint and not just the first one in the list #1520
Conversation
paulr34
force-pushed
the
bugFix_sharingZigbeeData
branch
from
a47dde6 to
610545d
Compare
paulr34
force-pushed
the
bugFix_sharingZigbeeData
branch
from
22114a3 to
b3174e1
Compare
| cy.fixture('data').then((data) => { | ||
| this.data = data | ||
| // If mode is "matter", set skipTest flag to true | ||
| if (this.data.mode === 'matter') { |
There was a problem hiding this comment.
Better to run it for zigbee than not matter. If a new protocol does not have attribute reporting then this test will fail.
|
|
||
| // Create and validate the first endpoint | ||
| cy.fixture('data').then((data) => { | ||
| cy.addEndpoint(data.endpoint4, data.cluster1) |
There was a problem hiding this comment.
I do not understand this as I am not familiar with what is happening here. Comment says first endpoint and cy.addEndpoint(data.endpoint4, data.cluster1) says data.endpoint4
There was a problem hiding this comment.
yes, this is just how cypress is setup for all tests but I agree it should be fixed and cleaned up. I will work on a follow up PR to fix Cypress in general
| '.q-virtual-scroll__content > :nth-child(1) > :nth-child(2) > .q-toggle > .q-toggle__inner > .q-toggle__thumb' | ||
| ).click() | ||
| // Check to make sure the button is still visible after clicking | ||
| cy.get( |
There was a problem hiding this comment.
I hope this test does not just get the next item in the list.
There was a problem hiding this comment.
I'm sorry I'm confused what you mean here
There was a problem hiding this comment.
I just don't really know how this checks in the UI when an attribute vanishes. If there are 2 attributes in the attribute reporting and one of them vanishes then does the second one just show up in the first one's place and pass this test?
Is it better to test by checking the number of attributes in attribute reporting before and after enablement?
There was a problem hiding this comment.
I see, it gets a specific one
There was a problem hiding this comment.
It doesn't just get the first one in the list but I will triple check
| '.q-virtual-scroll__content > :nth-child(1) > :nth-child(2) > .q-toggle > .q-toggle__inner > .q-toggle__thumb' | ||
| ).click() | ||
| // Check to make sure the button is still visible after clicking | ||
| cy.get( |
There was a problem hiding this comment.
I just don't really know how this checks in the UI when an attribute vanishes. If there are 2 attributes in the attribute reporting and one of them vanishes then does the second one just show up in the first one's place and pass this test?
Is it better to test by checking the number of attributes in attribute reporting before and after enablement?
There was a problem hiding this comment.
In the following PR to clean up Cypress test, we should rename these endpoints with their actual names. These random numbers are so confusing to read
"endpoint1": "Billing Unit (0x0203)",
"endpoint2": "CBA Config Tool (0x0005)",
"endpoint3": "Chatting Station (0x0601)",
"endpoint4": "CBA Thermostat (0x0301)",
I agree. Good idea. I'll whip something up for next week |
No description provided.