Properly report first exception

[filmor]

No description provided.

Dialyzer is not happy with this change.

[filmor]

Dialyzer not being happy with it just means that elvis_core is incorrectly speced (and not correctly checked by Dialyzer?), I'll have a look. With the current implementation, the case in question (forgot to set the ruleset value) will lead to "Linting failed" without any additional information.

[elbrujohalcon]

Dialyzer not being happy with it just means that elvis_core is incorrectly speced (and not correctly checked by Dialyzer?), I'll have a look. With the current implementation, the case in question (forgot to set the ruleset value) will lead to "Linting failed" without any additional information.

Let's open a ticket in elvis_core to adjust the specs, then :)

[paulo-ferraz-oliveira]

I don't see where elvis_core exceptions are "thrown" as {fail, [{throw, Error}|_]}, or what's catching them to transform an error into that, but I agree the tests could help developers by being more explicit in cases of e.g. badmatches.

Edit: hm, it's probably coming from

    catch
        {T, E} ->
            {error, {T, E}}

[paulo-ferraz-oliveira]

Once inaka/elvis_core#314 is approved+merged+tagged+released, this pull request can be updated to benefit from that and then approved+...

[paulo-ferraz-oliveira]

The above-mentioned pull request is in place, so this pull request can benefit from it.

[paulo-ferraz-oliveira]

Closing as superseded by #60. This seemed stale, and the solution seemed incomplete too. That, along with the Conflicting files, eased our choice.