Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mqtt shared Connection Support #14

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

skothari-tibco
Copy link
Contributor

@skothari-tibco skothari-tibco commented Sep 11, 2019

Can you please review and share your suggestions? Also should I add TLSConfig capability in shared connection?

Copy link
Contributor

@pointlander pointlander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is binary file example/mqtt-shared/bin/mqtt-shared checked in?

@skothari-tibco
Copy link
Contributor Author

Removed. Thanks.

activity/mqtt/activity.go Outdated Show resolved Hide resolved
activity/mqtt/activity.go Outdated Show resolved Hide resolved
activity/mqtt/metadata.go Show resolved Hide resolved
connections/mqtt/connection.go Outdated Show resolved Hide resolved
@@ -0,0 +1,71 @@
{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mellistibco should we have a top-level "examples" directory in this repo? or should we have an examples directory under the mqtt activity and mqtt trigger?

Maybe we should create a top-level mqtt directory like we are doing for mongodb and have an examples directory within it. and leave the old mqtt as is.

connections/mqtt/connection.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants